Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL ‘/hello’ rule in public site #4911

Closed
usingsky opened this issue Jul 19, 2019 · 1 comment · Fixed by #4913
Closed

URL ‘/hello’ rule in public site #4911

usingsky opened this issue Jul 19, 2019 · 1 comment · Fixed by #4913
Assignees

Comments

@usingsky
Copy link
Contributor

I suggest providing the /hello path only in debug mode.

CKAN Version if known (or site URL)

2.8

Please describe the expected behaviour

Ckan extension can determine whether to use /hello routing.

Please describe the actual behaviour

Currently ckan core provides the "/hello" path by default.
In a production build, I think this is unnecessary information for users.
There is no way to remove "/hello" routing from an extension without modifying the core, and it must be redefined.

What steps can be taken to reproduce the issue?

It is being routed on some sites based on ckan
eg)
https://demo.ckan.org/hello
https://data.stadt-zuerich.ch/hello
https://data.gov.ie/hello
https://ckan0.cf.opendata.inter.sandbox-toronto.ca/hello

amercader added a commit that referenced this issue Jul 19, 2019
This was used at the beginning of the Flask migration when there were no
actual endpoints migrated yet to Flask.
@amercader amercader self-assigned this Jul 19, 2019
@amercader
Copy link
Member

Thanks @usingsky . That's a leftover from the initial stages of the Flask migration. I've removed in #4913

smotornyuk added a commit that referenced this issue Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants