Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken dump link at bottom of dataset page #619

Closed
seanh opened this issue Mar 12, 2013 · 1 comment
Closed

Broken dump link at bottom of dataset page #619

seanh opened this issue Mar 12, 2013 · 1 comment
Milestone
CKAN 2.0

Comments

@seanh
Copy link
Contributor

seanh commented Mar 12, 2013

When ckan.dumps_url is not set in the config file you get:

You can also access this registry using the API (see API Docs) or download a . .
seanh pushed a commit that referenced this issue Mar 12, 2013
[#619] Fix broken dumps link on dataset page
9b178b0 
An if statement in a template was wrong, so if dumps_url was _not_ set
then ckan would try to show the dumps link and would render an empty
string. Reversing the if statements fixes it.
johnglover added a commit that referenced this issue Mar 13, 2013
@johnglover
Merge pull request #620 from okfn/619-bug-broken-dump-link-at-bottom-…
45f540a 
…of-dataset-page

[#619] Fix broken dumps link on dataset page
@johnglover
Copy link
Contributor

Pull request closed. Are we still agreed on attaching pull requests to existing issues rather than creating a separate pull request and issue? I think it's better to avoid the duplication.

seanh pushed a commit that referenced this issue Mar 13, 2013
@amercader
[#619] Fix broken dumps link on dataset page
bfd9372 
An if statement in a template was wrong, so if dumps_url was _not_ set
then ckan would try to show the dumps link and would render an empty
string. Reversing the if statements fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CKAN 2.0
Development

No branches or pull requests
2 participants
@seanh @johnglover