-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better template {% block %}s for CKAN 2.0 #688
Comments
It might be nice to also clean up the whole new dataset stuff but that can happen in 2.1 as we are so pressed for time |
@tobes Could I re-scope this to include adding more blocks to more templates? Because I've spotted a couple of templates that I'd like to add more blocks in for 2.0? |
@johnmartin if you are quick and update the title/description. Can you do each template as it's own commit so that we can decide if it gets into 2.0 or not on a template by template basis. |
@tobes Perfect, thanks. I'll do each template as a separate commit to make merging into |
@tobes OK, well... it's looking like this is going to touch ~45 template files. Are you still sure you want me to do them all as separate commits? |
maybe split it into sections of <=5 templates all related |
@amercader Just a reminder that this one is needed in 2.0, the SA site and ckanext-hidegroups plugins need this |
@seanh According to the PR (#704) this is 2.1 and only one commit should go to 2.0 (0f28d0f), which already is. Ca you catch up with @tobes and @johnmartin to see if the bits you need are there or other commits should be moved to 2.0? |
Yeah this should not merge into 2.0 due to the amount of noise. If there is a single commit you need then get that cherry-picked by all means but not all of this @seanh You may need to do a specific fix for 2.0 only to get the bit you need |
D'oh, this is the specific commit that I need: cfaf732 if it can be cherry-picked, without it ckanext-hidegroups will have to work differently on 2.0 or 2.1 or at least have to work in a non-optimal way |
@seanh @amercader cfaf732 is fine from my POV to be put into |
Merged cfaf732 in 2.0 🌻 |
Looks like it's in 2.0 now |
{% block %}
s are great. We should have more of them for CKAN 2.0.In particular the create dataset form (around step 2)
The text was updated successfully, but these errors were encountered: