Validation problem in term_translation_update_many #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
johnglover
added a commit
that referenced
this pull request
Jun 21, 2013
Now checks that data is present and that it is a list.
Now checks that data is present and that it is a list.
| {'error': | ||
| 'term_translation_update_many needs to have a list of dicts in field data'} | ||
| {'error': ['term_translation_update_many needs to have a ' | ||
| 'list of dicts in field data']} |
There was a problem hiding this comment.
do we want to change this from a string to a list?
There was a problem hiding this comment.
The API was not correctly returning the error message when this was a string (just the first letter). This should probably have a proper schema and go through the usual validation process at some point.
There was a problem hiding this comment.
@tobes Sorry my mistake: my original change was made in 1.8.1 but this seems to have been something that was fixed since then (str now uses ValidationError.error_dict instead of ValidationError.error_summary), so this can go back to being a string. I will push a fix.
johnglover
added a commit
that referenced
this pull request
Jun 24, 2013
…summary so this can go back to being a string.
johnglover
added a commit
that referenced
this pull request
Jun 24, 2013
…summary so this can go back to being a string.
|
@tobes Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no data is given then num is not defined here:
https://github.com/okfn/ckan/blob/master/ckan/logic/action/update.py#L776
This should be caught here, but for some reason we are also checking to see if data_dict is a list:
https://github.com/okfn/ckan/blob/master/ckan/logic/action/update.py#L768