Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recaptcha not working in CKAN 2.0 (jinja templates) #1070

Merged
merged 3 commits into from
Oct 16, 2013
Merged

Conversation

johnmartin
Copy link
Contributor

According to:
http://docs.ckan.org/en/latest/configuration.html?highlight=captcha

it should be possible to just add public and private keys to the config and get a working recaptcha. It is not shown on the login form however, it looks like the code was never added to the Jinja templates.

@ghost ghost assigned johnmartin Jul 18, 2013
@johnmartin
Copy link
Contributor

Note to merger: Requires a paster less after merge into master

@johnglover
Copy link
Contributor Author

@johnmartin A couple of things here:

  • I agree with @rgrp, it doesn't look like the private key is used anywhere here so if we don't need it then we should not load it in app_globals (and it shouldn't be in the config/docs).
  • The recaptcha is loading but are you sure that it is actually working? I was able to register despite leaving the recaptcha fields blank.
  • There seems to be a merge conflict now with this branch, would you mind merging with master when you get the chance?

Cheers.

@johnmartin
Copy link
Contributor

@johnglover

  • Removed private key from globals
  • It works for me. When I have a recaptcha key set I cannot register unless I fill in the correct captcha. I got no luck when using either a blank captcha or just a wrong one. Is it a issue where the recaptcha key is invalid or something?
  • Just merged master so the merge conflict is fixed now

@johnglover
Copy link
Contributor Author

@johnmartin thanks. It's a new global key and I did not getting any error messages so seems a bit strange. I'll have another look later on.

@johnglover
Copy link
Contributor Author

@johnmartin I had a problem with my private key that was failing silently, sorted now.

johnglover added a commit that referenced this pull request Oct 16, 2013
Recaptcha not working in CKAN 2.0 (jinja templates)
@johnglover johnglover merged commit d0920e9 into master Oct 16, 2013
@johnglover johnglover deleted the 1070-recaptcha branch October 16, 2013 15:52
pkoskinen pushed a commit to kata-csc/ckan that referenced this pull request Sep 12, 2014
pkoskinen pushed a commit to kata-csc/ckan that referenced this pull request Sep 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants