500 Error Upon Production Deployment #1111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new helper function to check if a resource can be previewed and adds it to the templates.
Also fixes for: * Group/Org edit template: added missing context in sidebar * Group/Org new template: added missing helper text * Small template refactors: moving group context info into snippet and also group/org helpers into snippets
Add tests that no activities are emitted when creating, updating or deleting private datasets via the API. These could be more detailed, e.g. test adding, deleting and updating groups as well, or moving the dataset between groups or between orgs, or testing what happens when a private dataset is made public or vice-versa.
Move the visibility option (public or private) when creating a dataset to the first stage of the dataset creation form. This fixes the issue (#953) that an activity is emitted when creating private datasets. Since the dataset is actually created when the first form is submitted, and the public/private setting is not chosen until the third form, the dataset is public at the moment when it's created and an activity is emitted. It seems to make a lot more sense fo the visibility option to be on the first form next to the organization option anyway. Fixes #953.
If a dataset has no owner organization, authorize anyone to read that dataset (regardless of whether it's public or private).
Fix the logic for displaying the Organization and Visibility dropdowns when creating or updating a dataset. We really need frontend tests for this. I tested these cases manually: User is not logged in and anon_create_dataset = True: neither Organization nor Visibility shows, either when creating or when updating a dataset. User is logged in, but is not a member of any organization: neither Organization nor Visibility shows, either when creating or when updating a dataset. Tested both when the site has no organizations and when the site does have orgs but user is not a member of any. User is logged in, and is a member of an organization: Both Organization and Visibility show when creating a dataset. When creating a private dataset, no activities appear in the activity stream. User is logged in, and is a member of an organization, but dataset is not a member of any org: neither Organization nor Visibility shows when updating a dataset. User is logged in, and is a member of an organization, and dataset is a member of any org: Visibility shows but Organization does not show when updating a dataset. User is sysadmin, site has no orgs: neither Organization nor Visibility shows when creating or updating a dataset. User is sysadmin, site does have orgs: both Organization and Visibility show when creating or updating a dataset.
Don't allow non-sysadmins to read inactive datasets. This fixes a test that was failing.
Add a validator to prevent private datasets with no organization from being created by package_create or package_update. Conflicts: ckan/logic/schema.py ckan/logic/validators.py
Essentially we get the current value of the visibility dropdown and then if no org is selected then we disable the visibilty dropdown and set it to be public. Conflicts: ckan/public/base/javascript/resource.config
A my datasets, my orgs and my groups pages. Each one showing ownership of the relevant items within it. Conflicts: ckan/templates/user/dashboard.html
Conflicts: ckan/templates/user/edit_base.html
…anups Conflicts: ckan/templates/group/snippets/group_item.html ckan/templates/organization/snippets/organization_item.html
Conflicts: ckan/templates/admin/config.html ckan/templates/admin/index.html ckan/templates/footer.html ckan/templates/package/search.html
|
Thanks for reporting this bug. The print statement in |
1 similar comment
|
Thanks for reporting this bug. The print statement in |
ghost
assigned 
|
Done in #1113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I was able to get CKAN working just fine locally, but trying to deploy per the instructions (http://docs.ckan.org/en/latest/deployment.html) gives me a 500 error. I checked permissions and everything is correct. Here's the log: