Auth aware group and org list action functions should return dictized objects #1172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
organization_list_for_user
andgroup_list_authz
create a dict with the Group objects before returning the list, when they should be callingmodel_dictize.group_list_dictize
as the rest.The whole groups list thing is a bit messy, with wrong docstrings, inconsistent docstrings and duplicated code.
organization_list_for_user
,group_list_authz
and_group_or_org_list
should all share the same code if possible, that you can be a separate issue.