'facet.limit' in package_search wrongly handled #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A negative value should be allowed if you don't want to limit the facet values, but the search params schema didn't allow it. Also mention in the docs that this can be set via configuration and that the default is 50. Added some tests.
ghost
assigned 
| @@ -1289,8 +1289,9 @@ def package_search(context, data_dict): | |||
| :param facet.mincount: the minimum counts for facet fields should be | |||
| included in the results. | |||
| :type facet.mincount: int | |||
| :param facet.limit: the maximum number of constraint counts that should be | |||
| returned for the facet fields. A negative value means unlimited | |||
| :param facet.limit: the maximum number of values the facet fields. A | |||
There was a problem hiding this comment.
I feel like this sentence is incomplete. Should it be the maximum number of values the facet fields returns?
|
@amercader Other than the small nit for the docstring, it seems to be okay. |
|
@amercader ping? |
|
@nigelbabu fixed |
nigelbabu
added a commit
that referenced
this pull request
Oct 15, 2013
'facet.limit' in package_search wrongly handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search params schema does not support negative values, but Solr supports it. Poor docs and no tests.