ValueError for non-int limit and offset query params #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
* Add decorator that validates against a given schema * Add default_activity_list_schema * Refactor user_activity list to use validator decorator
change tests, no need to hit the database we only need to test that the vaildators raise a ValidationError
remove kwargs, otherwise the resulting action functions have the incorrect function signature
move validation out of action function and into the schema to prevent 500 errors
|
'convert_to_json_if_string' seems a bit ridiculous but I wanted to keep the logic the same and something like 'is_json' would be misleading. :( |
|
Review - all looks good. Well worth having all these improvements in. A few get functions remain without the validation still - group_package_show, tag_search, tag_autocomplete, but these can be done in the future. I'm handing off to @kindly and recommending it is merged. |
kindly
added a commit
that referenced
this pull request
Dec 10, 2013
ValueError for non-int limit and offset query params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines obviously cause problems for non-int query params. This hit me as a 500 in production.
Since this is at least the third time for this kind of error to pop up, I'm strongly suggesting a proper pagination implementation to be used across resources. Something along the lines of:
There are many other places in
get.pywhere this is a problem.