Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1541] Add empty alt tag to gravatar #1565

Merged
merged 1 commit into from Jun 25, 2014
Merged

Conversation

rossjones
Copy link
Contributor

Adds an empty alt tag to the gravatar link generated by helpers to fix #1541

@rossjones
Copy link
Contributor Author

Should include something in the alt tag. 'gravatar' suggested

@mwainwright
Copy link

I disagree. The alt text is a text alternative to the picture of my gurning face. But the gurning face is purely decorative (it's linked to profile, my name also appears in the link) so reading in text mode, I don't need anything there. See

http://www.w3schools.com/tags/att_img_alt.asp

@rossjones
Copy link
Contributor Author

Well the PR is there to do what you want, I'll let you convince the others are to whether is should really be blank (in which case it added nothing), or gravatar, or the user's name.

@amercader amercader self-assigned this Mar 6, 2014
@nigelbabu
Copy link
Contributor

So, are we closing this or merging?

@seanh
Copy link
Contributor

seanh commented Apr 1, 2014

@rossjones Suggest alt text "Sean Hammond's gravatar" and then we should merge this. This doesn't fix #1541 though

@amercader amercader merged commit 839bd7e into master Jun 25, 2014
@amercader
Copy link
Member

Just merged it with an empty alt="" as the full name was not trivial to get from the function and I don't want to change its params. If someone feels strongly against it feel free to send a new PR.

@smotornyuk smotornyuk deleted the 1541-gravatar-alt-tag branch December 19, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alt text for widgets
5 participants