-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to compile less when minifying files - updated logic #176
Conversation
@tobes This is good. Just one thing: Would it be possible to move the less methods into their own paster command? Then have another paster command that was something like |
yeah I can do that not sure on the name but that will do for now |
@tobes What's the status on this patch? (I'd like to write the ckan 2.0 front end deploy process for @amercader) |
yeah I forgot about this it's on my todo list now |
@tobes Ping. |
we now have ready for re review |
|
||
|
||
class LessCommand(CkanCommand): | ||
'''Create minified versions of the given Javascript and CSS files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be something like:
'''Compile all root less documents into their CSS counterparts
OK, does this mean we can get rid of |
thanks, I'll fix the cut paste bugs :) with If you need more info we can discuss on irc or skype :) |
@johnmartin fixed docstring |
@tobes This is good. Except on thing: I was getting an error with running Is this a bug in master? Or is it something odd with my environment? |
this is a separate issue it is needed for development/deployment but not for using |
@tobes Perfect. I'll merge this. |
Patch to compile less when minifying files - updated logic
This is a sample patch to compile less css files when minifying css/js.
It uses node to compile but makes it part of the minification process.
In my mind the two should be done at the same time so one is not forgotten probably the pater command needs to be renamed. Also I'd be inclined to make it more specific so that we do not specify the directory for minification as we want public/base
I'm happy if people want this done differently.
It also creates the 'custom colour styles'
currently error checking is week