Incorrect link in Organization snippet on dataset page #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced use of `with` in the snippet.
|
This looks good to me. @amercader Can you add a quick test, please? |
nigelbabu
added a commit
that referenced
this pull request
Sep 4, 2014
[#1882] Incorrect link in Organization snippet on dataset page
amercader
added a commit
that referenced
this pull request
Sep 10, 2014
Replaced use of `with` in the snippet. Conflicts: ckan/templates/snippets/organization.html
amercader
added a commit
that referenced
this pull request
Sep 10, 2014
Replaced use of `with` in the snippet. Conflicts: ckan/templates/snippets/organization.html
amercader
added a commit
that referenced
this pull request
Sep 10, 2014
Replaced use of `with` in the snippet. Conflicts: ckan/templates/snippets/organization.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like if you define a variable inside a with statement on Jinja2 this variable is not available inside a block:
{% with truncate=truncate or 0, url=h.url_for(controller='organization', action='read', id=organization.name) %} <!-- url defined here --> {% block info %} <div class="module module-narrow module-shallow context-info"> {% if has_context_title %} <h2 class="module-heading"><i class="icon-building"></i> {{ _('Organization') }}</h2> {% endif %} <section class="module-content"> {% block inner %} {% block image %} <div class="image"> <a href="{{ url }}"> <!-- url not defined here --> ...This means an empty href, which effectively links to the same dataset page.