Can not override auth config options from tests #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the values can not be overriden from tests
The old auth tests are terrible in that they depend on each other to run. Also the auth cache thing masked some bad assumptions. The whole file should be rewritten as new tests.
Because `.bar` is being recognized as a gTLD, it points to `127.0.53.53`, which if you have a web server running will return localhost (and a 200 status). More details: https://stackoverflow.com/questions/25662590/domain-foo-bar-points-127-0-53-53-why
|
|
||
| if key == 'roles_that_cascade_to_sub_groups': | ||
| # This permission is set as a list of strings (space separated) | ||
| value = value.split(' ') if value else [] |
There was a problem hiding this comment.
how about split() with no argument? then it will split on any white-space (and any amount of it) and strips white-space on either side too.
…roups
Use split() rather than split(' ')
|
@wardi done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing auth tests, using the
@helpers.change_config()decorator on an auth option has no effect. The reason is that auth functions callnew_authz.py.check_config_permissionwhich caches the config and default values the first time is run.I think is worth not caching the values and allowing them to be overriden from tests than the performance gains.