fallback IDatasetForm plugins should force type, no fallback should force type='dataset' #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package_type = package_plugin.package_types()[0] | ||
| except (AttributeError, IndexError): | ||
| package_type = 'dataset' | ||
| # in case a 'dataset' plugin was registeres w/o fallback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem 1
IDatasetForm plugins may have an
is_fallback()method that returns True. Such a plugin may also have apackage_types()method that returns something other than['dataset'].In this case
package_createwith notypevalue will use the one plugin to validate dataset fields, but the dataset will be saved withtype='dataset'possibly causing a different plugin to be used forpackage_update.Problem 2
IDatasetForm plugins may have an
is_fallback()method that returns False. Such a plugin may also have apackage_types()method that returns['dataset'].In this case
package_createwith notypewill use the DefaultDatasetForm validate dataset fields, but the dataset will be saved withtype='dataset'causing the plugin to be used forpackage_update.