[#1753] Rename tests -> tests_legacy. #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2015 13:51
…nst ckanext-harvest/spatial/archiver/qa.
|
@davidread to prepare for renaming new_tests how about moving to |
|
Sounds good, i'll give it a try. |
|
@amercader you mentioned before you'd be up for renaming tests in CKAN 2.3. I think this PR is pretty straightforward, and the longer it is not merged, the harder it will be to merge, since it affects every legacy test. So can this go in the 2.3 milestone? Once this is merged I'll do a PR for moving new_tests to tests, and ideally that'd go into the same CKAN release. That would mean that tests in extensions will only need updating once. |
…tests Conflicts: ckan/tests/functional/api/base.py ckan/tests/legacy/lib/test_datapreview.py ckan/tests/legacy/lib/test_munge.py ckanext/imageview/tests/test_view.py ckanext/pdfview/tests/test_view.py ckanext/webpageview/tests/test_view.py setup.py
|
Whoop! |
This was referenced Mar 16, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can worry about renaming new_tests to tests once this has been merged, to reduce the chance of "noise between branches" mentioned here: #1753 (comment)