Moves the cli commands to a module #2223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all of the cli commands from a single file to a file-per-command in the ckan.lib.commands module. Unfortunately removing cli.py from the pep whitelist has made the pep8 command now start checking a lot of files that it didn't before - I suspect a bug in the pep8 test somewhere. As such, this is a WIP.
| @@ -953,4 +955,4 @@ def test_bad(self): | |||
| ' resolving\nWe should not be translating exceptions in most' | |||
| ' situations. We need to when the exception message is passed' | |||
| ' to the front end for example validation') | |||
| show_fails(msg, self.fails) | |||
| show_fails(msg, self.fails) | |||
There was a problem hiding this comment.
Found it - looks like you got rid of the final \n, which is what the PEP8 error is about. I'll commit the fix.
|
Hmmm I suspect this isn't going to be finished off and may not be worth merging all the updates since this was first worked on. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of the cli commands from a single file to a file-per-command in the ckan.lib.commands module.
Unfortunately removing cli.py from the pep whitelist has made the pep8 command now start checking a lot of files that it didn't before - I suspect a bug in the pep8 test somewhere.