add reset for reset_key on successful password change #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nateprewitt nice! Thanks. |
|
We're not adding new tests to tests/legacy at this time, would you move the test to tests/controllers/test_user.py instead? |
|
Yep, wasn't sure where to put it so I grouped it with the other perform_reset tests. I'll move it over now. |
|
I had to import create_reset_key from mailer.py to initialize the reset_key in the model. If there's a cleaner interface to do this, let me know and I'll make the fix. |
and associated test
|
@amercader how far can we backport this one? |
amercader
added a commit
that referenced
this pull request
May 11, 2015
Test adapted for older CKAN versions
amercader
added a commit
that referenced
this pull request
May 11, 2015
Test adapted for older ckan versions
|
@wardi all the way down to 2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and associated test.
Fix for #2370