Use names not IDs in follower flash messages #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can also produce these follower flash messages by using the URLs for following/unfollowing things, instead of the js buttons, e.g. http://pdeu.staging.ckanhosted.com/group/follow/59df2658-0024-4016-9e2d-6d537bd933fd or http://pdeu.staging.ckanhosted.com/group/unfollow/59df2658-0024-4016-9e2d-6d537bd933fd |
ghost
assigned
added 3 commits
February 22, 2013 12:17
Use user display names and group and package titles, not IDs, in "You are now following..." and "You are no longer following..." flash messages.
To make them consistent with the "You are now following..." and "You are
no longer following..." messages, just say e.g. "You are now following
{name}" not "You are now following dataset {name}".
|
@tobes I saw that the successful follow/unfollow flash messages were using IDs too so fixed those as well. Tests passed for me. I'll merge this even though it now contains a couple of my own commits, if you think that's ok? |
|
@seanh your commits look ok, even if the amount of work behind the scenes to get a datasets name is obscene- that's a different issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you click twice quickly on a Follow/Unfollow button then when the page loads you'll get a message like:
It should say the object's display name not id