Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow uppercase letters in local part of email when sending user invitations #2415

Merged
merged 3 commits into from
Jul 16, 2015
Merged

Allow uppercase letters in local part of email when sending user invitations #2415

merged 3 commits into from
Jul 16, 2015

Conversation

amercader
Copy link
Member

  • usernames must be lower case
  • user invitations generate a random username from local part of the submitted email address and some random number.
  • we shouldn't be assuming that the localpart of an email is always lower case. https://en.wikipedia.org/wiki/Email_address

just needs a .lower() in _get_random_username_from_email and a relevant test.

@joetsoi joetsoi self-assigned this May 5, 2015
@amercader
[#2415] Allow uppercase emails on user invites
88f99cf 
Just lowercase the user name created from the email address
@amercader
Copy link
Member

@joetsoi I took this off your hands as I was looking at the same code. Can you merge if you are happy?

joetsoi added a commit that referenced this pull request Jul 16, 2015
@joetsoi
Merge pull request #2415 from ckan/2415-uppercase-emails-on-user-invite
db19a58 
Allow uppercase letters in local part of email when sending user invitations
@joetsoi joetsoi merged commit db19a58 into master Jul 16, 2015
@joetsoi joetsoi deleted the 2415-uppercase-emails-on-user-invite branch July 16, 2015 09:05
amercader added a commit that referenced this pull request Jul 16, 2015
@amercader
[#2415] Allow uppercase emails on user invites
a14725e 
Just lowercase the user name created from the email address

Conflicts:
	ckan/tests/logic/action/test_create.py
amercader added a commit that referenced this pull request Jul 16, 2015
@amercader
[#2415] Allow uppercase emails on user invites
22ef036 
Just lowercase the user name created from the email address
amercader added a commit that referenced this pull request Jul 16, 2015
@amercader
[#2415] Allow uppercase emails on user invites
ebb6077 
Just lowercase the user name created from the email address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joetsoi joetsoi

Labels
zBackport 2.2.3 zBackport 2.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amercader @joetsoi