Fix dataset-purge Paster command #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dataset-purge command leaves dangling references to purged datasets in "member" table (so this fix takes care to remove those membership records before).
Handle the case when the command is invoked with a dataset name as its argument (dataset-ref).
|
whoops, this was for release-v2.2.2 will reset |
|
@drmalex07 closing this PR, please resubmit against master and we can backport it. |
|
@wardi , ok i will try it on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dataset purgecommand leaves dangling references to purged datasets in "member"table (so this fix takes care to remove those membership records before).
I came across this issue when trying to purge an organization (whose datasets were supposed to be purged before) and received a 5xx server error. This was happening because the process of purging an organization includes purging of membership records (but of course, the actual member datasets were now absent).
I have only tested this against 2.2.2, but from a quick look i think this also applies to 2.2.3.