Resource proxy fails if HEAD responds with 403 #2530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2412. Some servers[1] respond with a 403 to the initial HEAD request made by the resource_proxy extension[2], so don't attempt the GET request of the file.
[1]e.g. https://barnet.gov.uk/dam/jcr:7e9d19d0-071a-4209-9955-68485a5c937a/CSG_Overview_v0.2.pdf
[2]
ckan/ckanext/resourceproxy/controller.py
Lines 42 to 48 in 5304409