Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Po file checker does not take plurals into account #2613

Merged
merged 4 commits into from Nov 16, 2015
Merged

Conversation

amercader
Copy link
Member

So we have all these errors that have gone undetected and cause issues like #2454:

https://gist.github.com/amercader/2e960075d1313c4a6f07

Also we are not defining correctly some of the plural strings using ungettext:

    subject = ungettext(
        "1 new activity from {site_title}",
        "{n} new activities from {site_title}",
        len(activities)).format(
                site_title=pylons.config.get('ckan.site_title'),
                n=len(activities))

should be

    subject = ungettext(
        "{n} new activity from {site_title}",
        "{n} new activities from {site_title}",
        len(activities)).format(
                site_title=pylons.config.get('ckan.site_title'),
                n=len(activities))

@amercader amercader removed their assignment Sep 15, 2015
@joetsoi joetsoi self-assigned this Sep 17, 2015
@amercader amercader added this to the CKAN 2.5 milestone Oct 28, 2015
@joetsoi joetsoi merged commit 2a3d575 into master Nov 16, 2015
@joetsoi joetsoi deleted the 2613-fix-po-checker branch November 16, 2015 09:48
amercader added a commit that referenced this pull request Nov 17, 2015
`entity` is no longer used after #2613. Also removes the encoding bit as
it doesn't display the characters properly.

And it fixes a PEP8 breakage on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants