[WIP] Fix encoding of setup.py for non-ascii names #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the default-encoding so that what the user enters is utf8 and this stops the paster templates for exploding. Also sets the encoding on the setup.py template so that it can be run if it has utf8 chars in it This should fix #2636
| @@ -51,6 +51,9 @@ class CkanextTemplate(Template): | |||
| def check_vars(self, vars, cmd): | |||
| vars = Template.check_vars(self, vars, cmd) | |||
|
|
|||
| reload(sys) | |||
| sys.setdefaultencoding('utf-8') | |||
There was a problem hiding this comment.
yikes, this could have really surprising side effects. I think we should fix our bytes/unicode confusion issues where they lie instead of with a global flag like this.
There was a problem hiding this comment.
I think it's inside paster
rossjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default-encoding so that what the user enters is utf8 and
this stops the paster templates for exploding. Also sets the encoding
on the setup.py template so that it can be run if it has utf8 chars in it
This should fix #2636