Exception when viewing Organizations extended with IGroupForm #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brew
added a commit
to okfn/ckanext-panama
that referenced
this pull request
Sep 14, 2015
This continues the work for fluent with groups and organizations. It requires the PRs from ckan/ckanext-scheming#84 and ckan/ckan#2640.
joetsoi
added a commit
that referenced
this pull request
Sep 17, 2015
Exception when viewing Organizations extended with IGroupForm
tremblaysimon
pushed a commit
to geo-msp/ckan
that referenced
this pull request
Oct 26, 2015
This was referenced Dec 1, 2015
|
Added an issue for this: #2765 |
amercader
added a commit
to datopian/ckanext-opendatani
that referenced
this pull request
Dec 18, 2015
amercader
added a commit
to okfn/ckanext-datarequests
that referenced
this pull request
Feb 4, 2016
amercader
added a commit
to amercader/ckanext-datarequests
that referenced
this pull request
Feb 4, 2016
|
@amercader can we backport this to 2.4? I'll add the tag |
|
done @wardi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewing an organization that's been extended with IGroupForm causes an exception:
Exception: menu item 'organization_activity' need parameter 'offset'The default organization_activity route [1] doesn't include an
offsetparameter, but a new route is set up for custom IGroupForm plugins inlib/plugins.py[2], which does include theoffsetparam. Thegroup_activityroute includes the offset param, so it being missing from organization is likely an oversight.Suggest:
Add the offset parameter to the organization read_base.html template in the same way it is in the group read_base.html
Adding the
{offset}param to the default organization_activity route.[1]
ckan/ckan/config/routing.py
Line 319 in ed5fe6e
[2]
ckan/ckan/lib/plugins.py
Line 191 in ed5fe6e