Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos. #2700

Merged
merged 2 commits into from
Oct 22, 2015
Merged

Fixed typos. #2700

merged 2 commits into from
Oct 22, 2015

Conversation

LondonAppDev
Copy link
Contributor

Changed:

This form of validator is passed the all the fields and errors in a “flattened” form. -> This form of validator is passed to all the fields and errors in a “flattened” form..

Validator must fetch values from flattened_data may replace values in flattened_data. -> Validator must fetch values from flattened_data and may replace values in flattened_data.

@amercader
Copy link
Member

@LondonAppDev On the first sentence the original wording is not great but the sense is correct, perhaps a better option is:

"All fields and errors in a "flattened" form are passed to the validator"

(ie the validator is not passed to the fields)

You are right in the second, I'd also say "The validator must fetch" instead of "Validator must fetch"

@amercader amercader self-assigned this Oct 22, 2015
@amercader amercader merged commit 80ddf33 into ckan:master Oct 22, 2015
@amercader
Copy link
Member

Thanks for the patch @LondonAppDev

@LondonAppDev
Copy link
Contributor Author

No worries!

On Thu, Oct 22, 2015 at 4:19 PM Adrià Mercader notifications@github.com
wrote:

Merged #2700 #2700.


Reply to this email directly or view it on GitHub
#2700 (comment).

*Mark Winterbottom | *Full-Stack Software Engineer
Mobile: +44 (0) 7918 713 807
Website: http://mark.winterbottom.me
LinkedIn: https://www.linkedin.com/in/markwinterbottom
Blog: http://londonappdeveloper.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants