fixes error message when using GET on POST-only actions #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@perceptron-XYZ would you fix the pep8 error? This isn't perfect but it's better than what we have, so I'll merge it once the tests are passing. |
|
Yes sure. I'm on my way to office.I'll take a look when I come in.
|
|
@wardi I got the pep8 and test case fixed |
wardi
added a commit
that referenced
this pull request
Oct 29, 2015
fixes error message when using GET on POST-only actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When request_data is None and try_url_params, it basically means you are calling a POST-only action with GET method, the original error message is not quite clear. I bumped into the error message when I was calling organization_purge in the url bar in my browser, and it took me some time to figure out why, so I think the modification would give users a better idea what exactly went wrong