resource_edit incorrectly setting action to new instead of edit. #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -590,7 +590,8 @@ def resource_edit(self, id, resource_id, data=None, errors=None, | |||
|
|
|||
| context = {'model': model, 'session': model.Session, | |||
| 'api_version': 3, 'for_edit': True, | |||
| 'user': c.user or c.author, 'auth_user_obj': c.userobj} | |||
| 'user': c.user or c.author, 'auth_user_obj': c.userobj, | |||
| 'action': 'edit'} | |||
There was a problem hiding this comment.
What are the context changes needed for?
There was a problem hiding this comment.
Simple consistency. If a resource is being edited, the action is edit.
There was a problem hiding this comment.
But 'action' didn't exist in the context dict before. Is there a reason you're adding it here and below?
There was a problem hiding this comment.
Simple consistency. If a resource is being edited, the action is edit. O-O
TkTech
force-pushed
the
action_edit_master
branch
from
6f75ffd
to
c9ba1c6
Compare
wardi
added a commit
that referenced
this pull request
Oct 29, 2015
resource_edit incorrectly setting action to new instead of edit.
amercader
added
zBackport 2.3.4
zBackport 2.4.3
zBackport 2.5.2
and removed
zBackport 2.3.3
zBackport 2.4.2
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource_edit incorrectly setting
action='new'instead ofaction='edit'. This value being set properly is required for our extension to behave properly when setting field defaults (we only want to set a default value if action='new').