[#2234] Improve datastore connection checks on migration #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the datastore connection is set on the config file but the user or database don't actually exist, skip the migration. Note that this only happens when the config options are there but the datastore plugin is not loaded (like in many extensions that extend their test.ini with the core test-core.ini). Otherwise the connection will crash anyway during the loading of the plugin itself.
wardi
added a commit
that referenced
this pull request
Nov 19, 2015
[#2234] Improve datastore connection checks on migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the datastore connection is set on the config file but the user or
database don't actually exist, skip the migration.
Note that this only happens when the config options are there but the
datastore plugin is not loaded (like in many extensions that extend
their test.ini with the core test-core.ini). Otherwise the connection
will crash anyway during the loading of the plugin itself.