[POC] Decoupling config from Pylons #2843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently routes /api/4/* to a Flask controller which will then: 1. Only process GET requests 2. Not handle auth at all. Will require the DispatcherMiddleware be replaced to hand requests to Flask based on the paths that the Flask app says it can handle. Flask though will then be given a partial path and so the request path will need reconstituting.
Unfortunately we need to check the path for the request against a known list of partial paths that Flask knows about - and then we route those requests to Flask.
Flask won't let you jsonify lists, so we'll just do it ourselves
Taking the old CKAN code for identifying the user doesn't yet seem to work, I've ruled out the c object being the problem (i.e. I can manually set it) but Repoze doesn't appear to be setting REMOTE_USER in the environment, and so it isn't being used.
We need to make sure ther flask app is passed through the same middleware stack that the Pylons app is ...
Conflicts: requirements.txt
This is meant to be used in the ckan context. It will internally proxy to the Pylons and Flask configs
Instead of importing directly from Pylons, import from ckan.common If we really need to access the Pylons config object, then we can access it via config.pylons_config.
All these should be refactored anyway to use helpers.FunctionalTestBase
|
Closed in favour of #3163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2842