datastore: Prevent unicode/ascii conversion errors #2904
Conversation
| @@ -123,7 +123,7 @@ def _cache_types(context): | |||
| if 'nested' not in _type_names: | |||
| native_json = _pg_version_is_at_least(connection, '9.2') | |||
|
|
|||
| log.info("Create nested type. Native JSON: {0}".format( | |||
| log.info(u"Create nested type. Native JSON: {0}".format( | |||
There was a problem hiding this comment.
I'm sure the ValidationError changes below are correct, but is it safe to pass unicode to any logger that's configured? Have you tested this?
There was a problem hiding this comment.
How about using repr() for user-supplied values sent to logs. That seems safer.
|
You are right, it's usually not a good idea. Do you prefer |
|
@mordae |
Some error messages were causing the errors due to format conversion of unicode fields into str templates. Signed-off-by: Jan Dvořák <mordae@anilinux.org>
|
OK, let's make it simpler. These are just the |
|
And this should take care of the log messages as per your instruction. Is this acceptable? |
Logging statements had a potential to crash on unicode inputs. Make sure they are always escaped. Signed-off-by: Jan Dvořák <mordae@anilinux.org>
| @@ -1310,8 +1313,7 @@ def make_private(context, data_dict): | |||
|
|
|||
|
|
|||
| def make_public(context, data_dict): | |||
| log.info('Making resource {0} public'.format( | |||
| data_dict['resource_id'])) | |||
| log.info('Making resource {resource_id!r} public'.format(**data_dict)) | |||
There was a problem hiding this comment.
have you been using something other than UUIDs for your resource_ids?
There was a problem hiding this comment.
Nope, just being consistent and quoting all of them. It's UnicodeText in the model...
datastore: Prevent unicode/ascii conversion errors
|
@amercader This puts python reprs in our logs now, do you think that's a concern for backporting? |
|
As for the |
amercader
added
zBackport 2.3.4
zBackport 2.4.3
zBackport 2.5.2
and removed
Backport pending
labels
Some error messages were causing the errors due to format conversion of unicode fields into str templates.