Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better stacktrace for broken SOLR #2934

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Better stacktrace for broken SOLR #2934

merged 1 commit into from
Mar 31, 2016

Conversation

davidread
Copy link
Contributor

Proposed fixes:

  • The benefit of "raise" on its own is that the original stacktrace is made available, rather than creating a new stacktrace with "raise search_error". So its easier to debug.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

The benefit of "raise" on its own is that the original stacktrace is …
617f6e2 
…made available, rather than creating a new stacktrace with "raise search_error". So its easier to debug.
@wardi
Copy link
Contributor

wardi commented Mar 30, 2016

yes, please!

@wardi wardi self-assigned this Mar 31, 2016
@wardi wardi merged commit ef96305 into master Mar 31, 2016
@smotornyuk smotornyuk deleted the raise-better branch December 19, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wardi wardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidread @wardi