Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix + enable automatic docker image builds #2995

Merged
merged 17 commits into from
May 13, 2016
Merged

Fix + enable automatic docker image builds #2995

merged 17 commits into from
May 13, 2016

Conversation

deinok
Copy link
Member

@deinok deinok commented Apr 30, 2016

Little fix for docker Files
Please enable automatic building on Docker Hub.

It uses the official Postgres image, fixes the issue with Solr Image

Tested

@wardi wardi changed the title Master Fix + enable automatic docker image builds May 2, 2016
@@ -1 +0,0 @@
../../../ckan/config/solr/schema.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you duplicating this file now? For the solr schema we need a way to keep this file up to date with the current ckan solr schema, but also allow users to customize their solr schema.

How about using a volume shared between the ckan docker image and the solr one?

Deinok added 3 commits May 2, 2016 22:11
@wardi wardi self-assigned this May 3, 2016
@deinok
Copy link
Member Author

deinok commented May 4, 2016

@wardi for now, the best way is download the schema from GitHub.
On next pulls i will try to use official images of Solr, and try to simplyficate the code.
Thanks for your attention

@deinok
Copy link
Member Author

deinok commented May 4, 2016

Try it on docker with deinok/postgresql deinok/solr and deinok/ckan

@deinok deinok mentioned this pull request May 13, 2016
@wardi
Copy link
Contributor

wardi commented May 13, 2016

@deinok it sounds like you're interested in helping us maintain these files, that would be really appreciated as none of the current core developers are using them.

@wardi wardi merged commit aeb3863 into ckan:master May 13, 2016
@deinok
Copy link
Member Author

deinok commented May 13, 2016

@wardi Okey, in our work we are interested in CKAN, and we are going to use it in a project. It would be fantastic mantain the Docker files and improve them with more options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants