Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/RFC] Add group type to search facets. #3018

Closed
wants to merge 1 commit into from

Conversation

Psykar
Copy link
Contributor

@Psykar Psykar commented May 13, 2016

This is somewhat of a Request For Comment / WIP.

I'm looking at separating search facets by group type. This appears to be the easiest way, and shouldn't much if any overhead. I can't see an easy way to do the split on the results page unfortunately, but perhaps adding this info to the facet won't be frowned on, even if it's only so the info can be available for extensions / helpers / templates.

Currently I'm doing the display of the group type facets in an extension, manually splitting the organizations facet returned by solr based on the type this PR adds, but it requires hardcoding the group types (by overriding dataset_facets, before_search and the get_facet_items_dict helper)

So they can be used by helpers / templates / extensions.
This commit itself doesn't use the type anywhere.
@amercader amercader self-assigned this May 24, 2016
@kmbn
Copy link
Contributor

kmbn commented Jan 22, 2019

We decided to close old pull requests that are not actively worked on so that we can focus our effort and attention on PRs made against the current version of CKAN. A lot has changed in the last several months and many PRs will have gone stale or may now be in conflict with the latest version.

Please note: this isn't a judgement about the quality of your pull request. We just don't have the resources to review older PRs.

If you would like to reopen your PR (and update it if necessary), please do!

@kmbn kmbn closed this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants