[WIP/RFC] Add group type to search facets. #3018
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat of a Request For Comment / WIP.
I'm looking at separating search facets by group type. This appears to be the easiest way, and shouldn't much if any overhead. I can't see an easy way to do the split on the results page unfortunately, but perhaps adding this info to the facet won't be frowned on, even if it's only so the info can be available for extensions / helpers / templates.
Currently I'm doing the display of the group type facets in an extension, manually splitting the organizations facet returned by solr based on the type this PR adds, but it requires hardcoding the group types (by overriding
dataset_facets
,before_search
and theget_facet_items_dict
helper)