New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solr Docker Image Updated #3029
Conversation
Simplificates the creation of the ckan docker containers required
@wardi ping |
EXPOSE 80 | ||
|
||
RUN apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
FROM phusion/baseimage:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's pin a version instead. Otherwise our build won't be reproduceable
I've deleted and recreated the ckan/solr and ckan/postgresql images as automated builds. It seems like the ckan/ckan image isn't building automatically even though it's set to. I might have to delete and recreate it as well. Please pin the docker images we use for postgresql and solr should be to some specific release version and I'll merge. It's ok with me if our docker dependencies are ahead of the versions listed in the source install, because this is going to be bleeding edge for a while I'm sure. |
Probably we should transfer to ubuntu image. This will be on next PR
@wardi |
# Adding Files | ||
ADD ./solrconfig.xml \ | ||
https://raw.githubusercontent.com/deinok/ckan/master/ckan/config/solr/schema.xml \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ckan/ckan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget do this change before PR
@wardi Tested images, seems ok to merge, take a look please |
VOLUME ["/var/lib/ckan"] | ||
EXPOSE 80 | ||
RUN apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've switched this whole file to use DOS line endings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contrib/docker/solr/Dockerfile and contrib/docker/docker-cloud.yml too.
@wardi yes, i think i was modified, but its an workin version, I will full modify CKAN image in a next PR, it will enable more configuration using ENV and use Debian or Ubuntu images, now that images work better than phusion/baseimage. Also i see that there is a Docker repo in CKAN, but is dead. |
Would you use unix line endings instead? Changing the line endings makes it look like you changed the whole files |
Okey, will make the changes when i get home |
All files should be in LF End of Line
@wardi take a look ;) |
Updates the Solr Docker Image to 6.0 and CKAN Image requires less space in HD.
@wardi Please, enable Automatic-Build on Docker Hub as we talk. If you need help, please, contact me. This will enable the automatic update of the image every time the Dockerfiles are updated.