Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include '.sql' migrations (Fixes #3045) #3047

Merged
merged 1 commit into from
May 31, 2016

Conversation

grahame
Copy link
Contributor

@grahame grahame commented May 23, 2016

Fixes #3045

Proposed fixes:

install all migrations, include the migrations for 021 which are .sql files.

remove dead code from setup.py (the code in there made no
difference to the tarball produced by sdist.)

update MANIFEST.in to achieve what the stuff in setup.py
was trying to do.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • [X ] includes bugfix for possible backport

Please [X] all the boxes above that apply

remove dead code from setup.py (the code in there made no
difference to the tarball produced by sdist.)

update MANIFEST.in to achieve what the stuff in setup.py
was trying to do.
@amercader
Copy link
Member

@grahame can you summarize why the stuff you removed from setup.py is no longer needed? Does it actually prevent the sql files from being included?

Sorry, python packaging has always been hard to follow for me

@grahame
Copy link
Contributor Author

grahame commented May 24, 2016

@amercader: everything that was in setup.py is achieved through the MANIFEST.in file, so it was just duplication. I did a python setup.py sdist before and after my changes, and the only modification to the tarball produced was the inclusion of the 021 migration, and the documentation for migrations (which the config in setup.py was trying to include, unsuccessfully.)

@amercader amercader self-assigned this May 24, 2016
@amercader
Copy link
Member

For future reference package_data in setup.py is needed to support python setup.py bdist. Our release process uses python setup.py sdist so I think it's safe to remove for now.

@amercader amercader merged commit eefe7bf into ckan:master May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration 021 missing after pip install
2 participants