Add and test PEP 263 source file encoding specifications. #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 263 describes how to specify the encoding of a Python source file. This commit adds UTF-8 encoding specifications to all CKAN Python source files. It also adds a test which verifies that each source file does indeed have a UTF-8 encoding specification.
|
When #3068 is merged can you add a reference to the unicode docs on this page? http://docs.ckan.org/en/latest/contributing/python.html |
|
@amercader That's already part of #3068: python.rst. |
|
@torfsen thanks! you're now the latest author of every file in ckan :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work for #3006. It was originally submitted via #3049 but has been put into this separate PR to ease reviewing.
This PR adds PEP 263 encoding specifications to all Python source files. It also adds a test which checks that every Python source file does have an encoding specification.