Fix group, org member tables in mobile view #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This new CSS will potentially alter the styling of more tables than you intend, since it will apply to the first 3 columns of any table that uses |
|
@MrkGrgsn, I've added class in templates instead col tag. Issue with member table: Fixed: |
|
@wildcatzita , i just noticed, that you'll get the same effect if you omit with attribute on col tags, even without adding anything to css. Could you check this and update you PR if i right? |
|
@smotornyuk, fixed. Can yo check please? |
smotornyuk
reviewed
Feb 19, 2017
ckan/templates/group/members.html
Outdated
| <th scope="col"></th> | ||
| <th class="col-user">{{ _('User') }}</th> | ||
| <th class="col-role">{{ _('Role') }}</th> | ||
| <th class="col-actions"></th> | ||
| </tr> |
There was a problem hiding this comment.
Are you still need these classes?
|
I think it can be merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.