Allow IValidator to override existing validators #3865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardi
added a commit
that referenced
this pull request
Oct 11, 2017
wardi
added a commit
that referenced
this pull request
Oct 11, 2017
|
@amercader thanks! |
wardi
added a commit
to wardi/ckan
that referenced
this pull request
Feb 9, 2018
wardi
added a commit
to wardi/ckan
that referenced
this pull request
Feb 9, 2018
jguo144
pushed a commit
to OpenGov-OpenData/ckan
that referenced
this pull request
Feb 21, 2018
jguo144
pushed a commit
to OpenGov-OpenData/ckan
that referenced
this pull request
Feb 21, 2018
jguo144
pushed a commit
to OpenGov-OpenData/ckan
that referenced
this pull request
Jul 5, 2018
jguo144
pushed a commit
to OpenGov-OpenData/ckan
that referenced
this pull request
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where overriding a built-in or plugin-defined validator is much simpler than redefining a one or more whole schemas.
This change allows IValidator plugins to override existing validators, following the established "first plugin wins" pattern. Validators are usually simple functions and they can be created with a number of different function signatures, so we don't attempt to "chain" validators like we do when overriding action methods. one validator wins and is the only one that will be called.
Current behaviour is to raise a NameConflict error, this will no longer happen.
The core schema.py imports validator functions directly, should we change schema.py to call get_validator() as part of the same PR for consistency, or make this only affect schemas defined in plugins or with ckanext-scheming?