Allow overriding celery list params #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition 'if key in LIST_PARAMS' was never satisfied because config keys are lower case and LIST_PARAMS is upper case. This allow overriding the CELERY_IMPORTS, ADMINS and ROUTES in ckan config. Also overriding list params should extend existings values (i.e. for CELERY_IMPORTS)
|
@philpep thanks. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition 'if key in LIST_PARAMS' was never satisfied because config
keys are lower case and LIST_PARAMS is upper case.
This allow overriding the CELERY_IMPORTS, ADMINS and ROUTES in ckan
config.
Also overriding list params should extend existings values (i.e. for
CELERY_IMPORTS)