Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shell script for datastore DB creation in Docker #3986

Merged
merged 1 commit into from Jan 11, 2018

Conversation

spikeheap
Copy link
Contributor

Fixes #3985

Proposed fixes:

This PR wraps the existing SQL script in a shell executor to allow environment variables to be interpolated, specifically the datastore_ro password.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docker] datastore_ro password is not correctly set by the init scripts
4 participants