Check that page is a positive integer (Fixes #344) #401
Conversation
|
It isn't obvious to me where I would write a test for this. Can someone give a pointer? |
|
@nigelbabu Since this bug fix is in a controller, it'd be a frontend test that you would have to write. Frontend tests are in |
| @@ -282,7 +282,9 @@ def custom(self): | |||
| try: | |||
| page = int(request.params.get('page', 1)) | |||
| except ValueError: | |||
| abort(400, ('"page" parameter must be an integer')) | |||
| abort(400, ('"page" parameter must be a positive integer')) | |||
There was a problem hiding this comment.
should the error be translatable?
abort(400, _('"page" parameter must be a positive integer'))
There was a problem hiding this comment.
None of the errors in feed.py seem translated. Do you want me to tackle that in this pull request or move it to a different one?
There was a problem hiding this comment.
The only existing one I see is 'group not found' you may as well fix that here
ghost
assigned 
|
I'll merge this for now but might change the validation in #473. |
Check that page is a positive integer (Fixes #344)
No description provided.