Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar collapse responsive #4110

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Navbar collapse responsive #4110

merged 2 commits into from
Mar 14, 2018

Conversation

gocemitevski
Copy link
Contributor

Fixes #4109

Proposed fixes:

  • Clear .navbar-collapse floats and adjust side margins when screen size is below 768px

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

tino097
tino097 approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@tino097 tino097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tino097 tino097 merged commit c5c9250 into ckan:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tino097 tino097 tino097 approved these changes

Assignees

@tino097 tino097

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.navbar-collapse is not properly cleared below 768px
2 participants
@gocemitevski @tino097