Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade httpretty to 0.9.4 for Python 3 support #4229

Closed
wants to merge 3 commits into from
Closed

Upgrade httpretty to 0.9.4 for Python 3 support #4229

wants to merge 3 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 4, 2018

Helps with #3309

Proposed fixes:

Upgrade development requirement httpretty from 0.8.3 to 0.9.4 for Python 3 support.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

Upgrade development requirement [__httpretty__](https://github.com/gabrielfalcao/HTTPretty) from 0.8.3 to 0.9.4 for Python 3 support.
@amercader amercader self-assigned this May 8, 2018
@amercader
Copy link
Member

We've had lots of problems in the past with httpretty versions and tests that use Solr or the DataPusher, and sure enough there are already 2 failures related. It might just be that the tests need updating because of some change in httpretty, but in any case we need to get these fixed or rewritten before merging.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 15, 2018

The root cause is that Circle CI is testing on Python 2.7.6 (current is 2.7.15) and the current httpretty is relying on ssl.SSLContext which was added in Python 2.7.9.

@cclauss cclauss closed this Jul 18, 2018
@cclauss cclauss deleted the patch-3 branch July 18, 2018 11:20
@cclauss
Copy link
Contributor Author

cclauss commented Jul 21, 2018

In CircleCI on the pip install -r dev-requirements.txt step we are getting these warnings:

  • httpretty 0.8.3 has requirement urllib3==1.7.1, but you'll have urllib3 1.23 which is incompatible.
  • mox3 0.25.0 has requirement pbr!=2.1.0,>=2.0.0, but you'll have pbr 1.10.0 which is incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants