Updated code to show Save and add more button while editing datasets #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amercader
reviewed
Oct 4, 2018
| {% if stage %} | ||
| <button class="btn btn-primary" name="save" value="go-metadata" type="submit">{{ _('Finish') }}</button> | ||
| {% else %} | ||
| <button class="btn btn-primary" name="save" value="go-dataset-complete" type="submit">{{ _('Finish') }}</button> |
There was a problem hiding this comment.
Can we keep the "Add" label on this case? I think it makes more sense to keep the existing message.
|
Thanks a lot @ashmeet-kandhari this works as expected, only one minor comment and it's good to go |
|
Hi @amercader i have reverted all the changes and just added the if-else logic now. |
|
Thanks @ashmeet-kandhari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed fixes:
Features:
Please [X] all the boxes above that apply