Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 and tidy #4602

Merged
merged 2 commits into from
Dec 21, 2018
Merged

PEP8 and tidy #4602

merged 2 commits into from
Dec 21, 2018

Conversation

davidread
Copy link
Contributor

@davidread davidread commented Dec 21, 2018

This is extracted from #3972

The only functional change is: <h2> -> <h1> which is for consistency with others of type: {% block primary_content_inner %}

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

This is extracted from #3972

The only functional change is: <h2> -> <h1> which is for consistency with
others of type: {% block primary_content_inner %}
@@ -1403,6 +1403,13 @@ def test_package_works_without_user_in_context(self):
'''
logic.get_action('package_search')({}, dict(q='anything'))

def test_local_parameters_not_supported(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved this test into a more appropriate class

{% endblock %}
</section>
{% endblock %}
{% block resources %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice spot! dunno how that slipped through!

@wardi
Copy link
Contributor

wardi commented Dec 21, 2018

replace the tab character with spaces and this looks fine to me

@davidread davidread merged commit 828c9b2 into master Dec 21, 2018
@davidread davidread deleted the pep8-and-tidy branch June 24, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants