Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing credentials and tls configuration to error email handler #4711

Merged
merged 1 commit into from May 28, 2019
Merged

Add missing credentials and tls configuration to error email handler #4711

merged 1 commit into from May 28, 2019

Conversation

Zharktas
Copy link
Member

@Zharktas Zharktas commented Mar 29, 2019 •
edited

Fixes #4611

Proposed fixes:

The previous fix #4623 did not include credentials or TLS attributes, so email sending failed if some email service was used. This remedies that oversight.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@davidread
Copy link
Contributor

@Zharktas can we have a unit test?

@davidread davidread self-assigned this Apr 2, 2019
@davidread davidread merged commit 236f245 into ckan:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidread davidread

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error emails are not sent in flask routes
2 participants
@Zharktas @davidread