Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable email validator to exclude malformed dots usage in email addre… #4720

Merged
merged 3 commits into from
Apr 12, 2019
Merged

enable email validator to exclude malformed dots usage in email addre… #4720

merged 3 commits into from
Apr 12, 2019

Conversation

sivang
Copy link
Member

@sivang sivang commented Apr 6, 2019 •
edited

…sses, fixes github #4719

Fixes #

Proposed fixes:

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@amercader amercader self-assigned this Apr 9, 2019
@amercader
Copy link
Member

@sivang if we clearly mark which lines in the regexp come from html.spec.whatwg.org and which don't this is good to go

@sivang sivang mentioned this pull request Apr 11, 2019
Merged
@sivang
Copy link
Member Author

sivang commented Apr 11, 2019

dots lookup pattern taken from here:

@amercader amercader merged commit 6eec1c4 into ckan:master Apr 12, 2019
@amercader amercader mentioned this pull request Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amercader amercader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sivang @amercader