Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlalchemy-migrate and pbr #4739

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Upgrade sqlalchemy-migrate and pbr #4739

merged 2 commits into from
Apr 23, 2019

Conversation

davidread
Copy link
Contributor

Upgrades:

  • sqlalchemy-migrate 0.10.0->0.12.0 (latest)
  • pbr 1.10.0->5.1.3 (latest)

These are upgraded for the sake of being up to date.

sqlalchemy-migrate releases. There doesn't seem to be an up-to-date changelog, but 0.11 is mentioned here. This sort of annoyance is another reason to move to Alembic - work started here.

pbr was quite out of date. It "manages setuptools packaging", and I think it is only used by sqlalchemy-migrate.

I've tested this like this:

  • tests pass, including with --ckan-migration option
  • with a database from CKAN 2.3, upgrading to this version of CKAN, running paster db upgrade and then manually clicking around web interface ok.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@@ -17,7 +17,6 @@ flask-babel==0.11.2
flask==0.12.4
formencode==1.3.1 # via pylons
funcsigs==1.0.2 # via beaker
html5lib==1.0.1 # via bleach
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (like other changes) to requirements.txt was made by pip-compile. html5lib is no longer an explicit dependency because it is now included as part of the bleach package - see mozilla/bleach#386

@wardi wardi merged commit 35fc513 into master Apr 23, 2019
@davidread davidread deleted the sqlalchemy-migrate-0.12.0 branch June 24, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants