Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Python identity is not the same thing as equality #4752

Merged
merged 1 commit into from
Apr 30, 2019
Merged

In Python identity is not the same thing as equality #4752

merged 1 commit into from
Apr 30, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 26, 2019

Fixes #4674

Proposed fixes:

is --> ==
is not --> !=

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@amercader amercader merged commit 42da3ce into ckan:master Apr 30, 2019
@amercader
Copy link
Member

@cclauss Thanks! Can we add the flag that catches these to the flake8 tests?

@cclauss cclauss deleted the indentity-is-not-equality branch April 30, 2019 12:51
@cclauss cclauss mentioned this pull request May 8, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use ==/!= to compare str, bytes, and int literals
2 participants
@cclauss @amercader