Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows use of external database or renaming of docker database service. #4771

Closed
wants to merge 1 commit into from

Conversation

ctownsen357
Copy link
Contributor

Fixes #
This allows one to use an external PostgreSQL database rather than requiring the docker ckan container to point to the db service within the compose file. In our case this allows us to point our containers to an AWS RDS instance. This change programmatically determines the database host based on the required CKAN_SQLALCHEMY_URL environment variable rather than leaving it hard coded to the compose service name.

This change also allows the system to fail fast if required environment variables are not set rather than waiting for the database to be available before testing the environment variables.

Proposed fixes:

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@ctownsen357 ctownsen357 closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant