Allows use of external database or renaming of docker database service. #4771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
This allows one to use an external PostgreSQL database rather than requiring the docker ckan container to point to the
db
service within the compose file. In our case this allows us to point our containers to an AWS RDS instance. This change programmatically determines the database host based on the requiredCKAN_SQLALCHEMY_URL
environment variable rather than leaving it hard coded to the compose service name.This change also allows the system to fail fast if required environment variables are not set rather than waiting for the database to be available before testing the environment variables.
Proposed fixes:
Features:
Please [X] all the boxes above that apply